Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rely on AtomsIO for structure parsing #802

Merged
merged 13 commits into from
Dec 20, 2022
Merged

Rely on AtomsIO for structure parsing #802

merged 13 commits into from
Dec 20, 2022

Conversation

mfherbst
Copy link
Member

@mfherbst mfherbst commented Dec 18, 2022

Requires fixes in JuliaMolSim/AtomsBase.jl#58.

@mfherbst mfherbst added the breaking Breaks public API and requires major version bump label Dec 18, 2022
@mfherbst mfherbst marked this pull request as draft December 19, 2022 06:29
Copy link
Member

@antoine-levitt antoine-levitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay for removing stuff!

Project.toml Show resolved Hide resolved
docs/src/guide/installation.md Show resolved Hide resolved
examples/atomsbase.jl Outdated Show resolved Hide resolved
examples/atomsbase.jl Outdated Show resolved Hide resolved
examples/gaas_surface.jl Outdated Show resolved Hide resolved
examples/gaas_surface.jl Outdated Show resolved Hide resolved
examples/input_output.jl Outdated Show resolved Hide resolved
examples/silicon.jl Outdated Show resolved Hide resolved
src/Model.jl Outdated Show resolved Hide resolved
@mfherbst mfherbst marked this pull request as ready for review December 20, 2022 13:41
@mfherbst mfherbst enabled auto-merge (squash) December 20, 2022 13:47
@mfherbst mfherbst merged commit a9764b4 into master Dec 20, 2022
@mfherbst mfherbst deleted the aseconvert branch December 20, 2022 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaks public API and requires major version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants