Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move binaries to jll packages #41

Merged
merged 3 commits into from
Jan 26, 2020
Merged

Conversation

aviks
Copy link
Contributor

@aviks aviks commented Jan 25, 2020

This uses the BinaryBuilder built binaries via jll packages.

The binding name has changed, but I havent changed the source yet. Hence this will show lots of deprecation errors when testing. I will make that change (in this PR) once the basic strategy is reviewed and accepted. Doing it now will cause very large diffs that will be impossible to review.

This PR changes the minimum required Julia version to 1.3. Backporting these to Julia 1.0-1.2 is going to be well nigh impossible -- the long chain of library depedencies, particularly for SDL2_image makes this infeasible. Of course, this is the most controversial part of this PR. Personally, I feel that is OK -- existing users will continue to use existing versions of this package.

Superseeds #39. Once this is merged, I will rebase #30 on top of this.

@jonathanBieler
Copy link
Collaborator

jonathanBieler commented Jan 25, 2020

Awesome, thanks ! I'm fine with the v1.3 restriction and the overall plan.

@giordano
Copy link
Contributor

Try now again, there is a new version of SDL2_jll.

@aviks
Copy link
Contributor Author

aviks commented Jan 25, 2020

I'm fine with the v1.3 restriction and the overall plan.

Great!

Tests passed locally on my windows machine, but struggling to get it working on Travis. Will keep trying, the new SDL2_jll should help.

@giordano
Copy link
Contributor

Tests passed locally on my windows machine, but struggling to get it working on Travis.

Tests are passing locally also for me on GNU/Linux, but failing on Travis. There might be some problems with headless tests?

Also, Travis installation of Windows is not great for multimedia packages, it is known for example that FFMPEG cannot possibly work because of missing libraries: JuliaIO/FFMPEG.jl#14. I'd try first on AppVeyor.

@giordano
Copy link
Contributor

I'd try first on AppVeyor.

aviks#1

@aviks
Copy link
Contributor Author

aviks commented Jan 25, 2020

@giordano Mac is still failing with the iconv issue.

@giordano
Copy link
Contributor

Mac is still failing with the iconv issue.

Yes, I saw that, this time is in SDL2_image. I'm on it.

@giordano
Copy link
Contributor

@aviks it should be fixed now

@aviks
Copy link
Contributor Author

aviks commented Jan 26, 2020

@jonathanBieler: I think this is ready to merge now, at your pleasure.

@giordano: As always, couldn't have done it without you. Grazie!

@jonathanBieler jonathanBieler merged commit 88dbc01 into JuliaMultimedia:master Jan 26, 2020
@jonathanBieler
Copy link
Collaborator

Thanks for all the work with the binaries dependency, I got a new mac recently and it's so much straightforward to install things than with the previous system.

Copy link
Collaborator

@NHDaly NHDaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So neat! Thanks for the great work, all! 😁

@NHDaly NHDaly mentioned this pull request Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants