-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move binaries to jll packages #41
Conversation
Awesome, thanks ! I'm fine with the v1.3 restriction and the overall plan. |
Try now again, there is a new version of |
Great! Tests passed locally on my windows machine, but struggling to get it working on Travis. Will keep trying, the new SDL2_jll should help. |
Tests are passing locally also for me on GNU/Linux, but failing on Travis. There might be some problems with headless tests? Also, Travis installation of Windows is not great for multimedia packages, it is known for example that FFMPEG cannot possibly work because of missing libraries: JuliaIO/FFMPEG.jl#14. I'd try first on AppVeyor. |
|
@giordano Mac is still failing with the iconv issue. |
Yes, I saw that, this time is in |
@aviks it should be fixed now |
@jonathanBieler: I think this is ready to merge now, at your pleasure. @giordano: As always, couldn't have done it without you. Grazie! |
Thanks for all the work with the binaries dependency, I got a new mac recently and it's so much straightforward to install things than with the previous system. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So neat! Thanks for the great work, all! 😁
This uses the BinaryBuilder built binaries via jll packages.
The binding name has changed, but I havent changed the source yet. Hence this will show lots of deprecation errors when testing. I will make that change (in this PR) once the basic strategy is reviewed and accepted. Doing it now will cause very large diffs that will be impossible to review.
This PR changes the minimum required Julia version to 1.3. Backporting these to Julia 1.0-1.2 is going to be well nigh impossible -- the long chain of library depedencies, particularly for
SDL2_image
makes this infeasible. Of course, this is the most controversial part of this PR. Personally, I feel that is OK -- existing users will continue to use existing versions of this package.Superseeds #39. Once this is merged, I will rebase #30 on top of this.