Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Julia v1.9 compatibility? #19

Closed
oschulz opened this issue Mar 20, 2023 · 2 comments · Fixed by JuliaLang/Pkg.jl#3435
Closed

Julia v1.9 compatibility? #19

oschulz opened this issue Mar 20, 2023 · 2 comments · Fixed by JuliaLang/Pkg.jl#3435

Comments

@oschulz
Copy link

oschulz commented Mar 20, 2023

Does ArtifactUtils.jl need an update for Julia v1.9? With v1.9.0-rc1 is always get an ERROR: ArgumentError: "" is not a directory (v1.8 works fine, of course):

julia> using ArtifactUtils, Artifacts # Artifacts provides the artifact string macro

julia> add_artifact!(
                     "Artifacts.toml",
                     "JuliaMono",
                     "https://github.com/cormullion/juliamono/releases/download/v0.030/JuliaMono.tar.gz",
                     force=true,
                    )
ERROR: ArgumentError: "" is not a directory
Stacktrace:
 [1] tempname(parent::String; max_tries::Int64, cleanup::Bool)
   @ Base.Filesystem ./file.jl:567
 [2] tempname
   @ ./file.jl:566 [inlined]
 [3] bind_artifact!(artifacts_toml::String, name::String, hash::Base.SHA1; platform::Nothing, download_info::Vector{Tuple{String, String}}, lazy::Bool, force::Bool)
   @ Pkg.Artifacts /opt/julia-1.9/share/julia/stdlib/v1.9/Pkg/src/Artifacts.jl:226
 [4] bind_artifact!
   @ /opt/julia-1.9/share/julia/stdlib/v1.9/Pkg/src/Artifacts.jl:163 [inlined]
 [5] add_artifact!(artifacts_toml::String, name::String, tarball_url::String; clear::Bool, options::Base.Pairs{Symbol, Bool, Tuple{Symbol}, NamedTuple{(:force,), Tuple{Bool}}})
   @ ArtifactUtils /user/.julia/packages/ArtifactUtils/LygoX/src/ArtifactUtils.jl:72
 [6] top-level scope
   @ REPL[4]:1
simeonschaub added a commit to JuliaLang/Pkg.jl that referenced this issue Apr 5, 2023
simeonschaub added a commit to JuliaLang/Pkg.jl that referenced this issue Apr 5, 2023
KristofferC pushed a commit to JuliaLang/Pkg.jl that referenced this issue Apr 11, 2023
IanButterworth pushed a commit to IanButterworth/Pkg.jl that referenced this issue Apr 11, 2023
@simeonschaub
Copy link
Member

Addressed by JuliaLang/Pkg.jl#3435, should be fixed in the official 1.9 release

@oschulz
Copy link
Author

oschulz commented Apr 11, 2023

Thanks @simeonschaub !

IanButterworth added a commit to JuliaLang/Pkg.jl that referenced this issue Apr 13, 2023
Co-authored-by: Stefan Karpinski <[email protected]>
Co-authored-by: Simeon Schaub <[email protected]>
fix minor print bug (#3431)
fix handling of relative paths in `bind_artifact!` (#3435)
Fixes JuliaPackaging/ArtifactUtils.jl#19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants