Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't mutate docs/Manifest.toml in CI #11

Merged
merged 2 commits into from
Dec 16, 2021
Merged

Conversation

tkf
Copy link
Collaborator

@tkf tkf commented Dec 14, 2021

While writing #10, I noticed that docs/Manifest.toml was stale. But, the doc build has been working in the CI because it mutates docs/Manifest.toml via

https://github.com/simeonschaub/ArtifactUtils.jl/blob/6f67e4cc599ca4be8f5e6fc8d93b7d8e76b35d84/.github/workflows/ci.yml#L61

If we remove this line (as suggested in this PR), a stale docs/Manifest.toml would have caught in the CI: https://github.com/simeonschaub/ArtifactUtils.jl/runs/4516845588?check_suite_focus=true#step:5:8

Alternatively, we can also simply remove docs/Manifest.toml and keep Pkg.develop.

@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2021

Codecov Report

Merging #11 (733424a) into main (6f67e4c) will not change coverage.
The diff coverage is n/a.

❗ Current head 733424a differs from pull request most recent head 7da6878. Consider uploading reports for the commit 7da6878 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main      #11   +/-   ##
=======================================
  Coverage   49.17%   49.17%           
=======================================
  Files           3        3           
  Lines         181      181           
=======================================
  Hits           89       89           
  Misses         92       92           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f67e4c...7da6878. Read the comment docs.

@tkf tkf marked this pull request as ready for review December 14, 2021 07:39
@tkf tkf mentioned this pull request Dec 16, 2021
@tkf tkf merged commit 00a40db into JuliaPackaging:main Dec 16, 2021
@tkf tkf deleted the docs-manifest branch December 16, 2021 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants