Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

String -> AbstractString #171

Merged
merged 2 commits into from
Sep 17, 2015
Merged

String -> AbstractString #171

merged 2 commits into from
Sep 17, 2015

Conversation

yuyichao
Copy link
Contributor

Fix deprecation warnings...

@yuyichao
Copy link
Contributor Author

May require JuliaLang/Compat.jl#139 for 0.3.

@yuyichao yuyichao force-pushed the yyc/0.4-string branch 2 times, most recently from 780fc41 to 77b4339 Compare September 16, 2015 16:48
@tkelman
Copy link
Contributor

tkelman commented Sep 16, 2015

I'm guesing coverage is probably pretty bad here. What code paths might hit the lower(s::Void,collection) method? If that relies on a not-yet-tagged version of Compat then it'll have to wait for that version to be tagged and reflected in REQUIRE here.

Want to be careful not to break 0.3 of course.

@yuyichao
Copy link
Contributor Author

Bump Compat requirement to 0.7.1 .

Not sure what's the best way to trigger lower(s::Void, collection). I added a @test BinDeps.lower(nothing, nothing) === nothing in the test. Someone more familiar with this could probably come up with better test than this....

@yuyichao
Copy link
Contributor Author

@tkelman Can I take your JuliaLang/julia#13107 (comment) as this PR has been tested? =)

@tkelman
Copy link
Contributor

tkelman commented Sep 17, 2015

Briefly, but only on 0.4. I trust if this breaks anything on 0.3 you'll be available to fix it.

@yuyichao
Copy link
Contributor Author

I trust if this breaks anything on 0.3 you'll be available to fix it.

Fine. I'll keep an eye on it while I'm figuring out how to get PkgEval working.

yuyichao added a commit that referenced this pull request Sep 17, 2015
@yuyichao
Merge pull request #171 from JuliaLang/yyc/0.4-string
5226643 
String -> AbstractString
@yuyichao yuyichao merged commit 5226643 into master Sep 17, 2015
@yuyichao yuyichao deleted the yyc/0.4-string branch September 17, 2015 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuyichao @tkelman