Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

precompile find_artifact_dir #53

Merged
merged 1 commit into from
May 1, 2023

Conversation

IanButterworth
Copy link
Member

Seems to be beneficial

Before

julia> @time_imports using LLVMExtra_jll
      0.4 ms  LazyArtifacts
     10.7 ms  Preferences
      1.0 ms  JLLWrappers
               ┌ 35.1 ms LLVMExtra_jll.__init__() 11.12% compilation time
     82.6 ms  LLVMExtra_jll 59.69% compilation time

This PR

julia> @time_imports using LLVMExtra_jll
      0.5 ms  LazyArtifacts
     10.9 ms  Preferences
      0.7 ms  JLLWrappers
               ┌ 6.5 ms LLVMExtra_jll.__init__() 55.44% compilation time
     50.0 ms  LLVMExtra_jll 90.38% compilation time

@codecov
Copy link

codecov bot commented May 1, 2023

Codecov Report

Merging #53 (7c3d1e1) into master (5b14792) will increase coverage by 2.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
+ Coverage   54.05%   56.10%   +2.05%     
==========================================
  Files           7        7              
  Lines         222      221       -1     
==========================================
+ Hits          120      124       +4     
+ Misses        102       97       -5     
Impacted Files Coverage Δ
src/wrapper_generators.jl 80.76% <100.00%> (+17.80%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@giordano giordano merged commit e793874 into JuliaPackaging:master May 1, 2023
@IanButterworth IanButterworth deleted the ib/precompile branch May 2, 2023 03:15
contra-bit pushed a commit to contra-bit/JLLWrappers.jl that referenced this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants