Fixed Freeze and removed warnings #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Culprit: JuliaLang/julia#9007 |
| @@ -48,11 +48,11 @@ end | |||
| if VERSION >= v"0.3-" | |||
| res = ccall((:URLDownloadToCacheFileW,:urlmon),stdcall,Cuint, | |||
| (Ptr{Void},Ptr{Uint16},Ptr{Uint16},Clong,Cint,Ptr{Void}), | |||
| 0,utf16(source),dest,sizeof(dest)>>1,0,0) | |||
| C_NULL,utf16(source),dest,sizeof(dest)>>1,0,C_NULL) | |||
| else | |||
There was a problem hiding this comment.
It doesn't look like this branch should ever be taken, since REQUIRE specifies julia 0.3?
There was a problem hiding this comment.
True..unsafe_convert is not needed!
|
Oh so the same stuff happend over there: |
|
Yikes, yeah 0.4 has a lot of recently-inflicted brokenness. WinRPM does tend to only get tested indirectly, but we can certainly add tests and set up appveyor here. Last time I tried to use WinRPM from Linux it wasn't able to do anything especially useful. |
|
you should be able to use all of the functionality on linux by specifying an architecture string to the various functions |
tkelman
added a commit
that referenced
this pull request
Jul 24, 2015
Fixed Freeze and removed warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did not test on 0.3, but
unsafe_convertis in Compat, right?Does this most crucial package actually have no test at all!?