Put the GCC DLL replacement back #97
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 31, 2017
|
I am trying to "fix IPOPT' on a new machine now and when I run I get |
|
did you see a at all? |
This reverts commit 0312fb0.
yuyichao
reviewed
Aug 5, 2017
deps/build.jl
Outdated
| @@ -6,7 +6,7 @@ if is_windows() | |||
| winrpm_bin = joinpath(WinRPM.installdir, "usr", Sys.MACHINE, | |||
| "sys-root", "mingw", "bin") | |||
| dlls = ["libgfortran-4", "libquadmath-0", "libstdc++-6", "libwinpthread-1", | |||
| "libssp-0", Compat.Sys.WORD_SIZE==32 ? "libgcc_s_sjlj-1" : "libgcc_s_seh-1"] | |||
| "libssp-0", Sys.WORD_SIZE==32 ? "libgcc_s_sjlj-1" : "libgcc_s_seh-1"] | |||
There was a problem hiding this comment.
WORD_SIZE was exported Base symbol so it was available in the Sys module even before it was moved there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will help with jump-dev/Ipopt.jl#77 - the change in threading model broke a bunch of packages. This is a little risky because upstream changes might end up causing the downloaded dll's to not work, but you should always be able to put the most recently working
-copyversions back if that happens.