add -O2 to GEOS CFLAGS

[jaakkor2]

Looks like dynamic libraries of GEOS are unstripped and huge in size.

In .julia\artifacts\899bb0e10d4accc34dff74b1c82ffbfe56dc8b23\bin, libgeos-3-8-0.dll and libgeos_c-1.dll are 57339 KB and 3239 KB respectively, whereas in .julia\conda\3\pkgs\geos-3.8.0-h33f27b4_0\Library\bin, geos.dll and geos_c.dll are 1346 KB and 346 KB respectively.

Putting here CFLAGS="${CFLAGS} -O2" to the ./configure line.

But somehow I would expect the builder defaults should produce reasonably-sized binaries?

[giordano]

But somehow I would expect the builder defaults should produce reasonably-sized binaries?

BinaryBuilder just does whatever is told to do 🙂

[visr]

Nice, is this similar to what happens in CMake with -DCMAKE_BUILD_TYPE=Release?
For GEOS they modernized the CMake usage in this release, we may also want to consider switching to that, since it seems like all GEOS CI is using this as well now, and it's usage is better documented.

https://github.com/libgeos/geos/blob/3.8.0/INSTALL

[jaakkor2]

Judging from https://github.com/JuliaBinaryWrappers/GEOS_jll.jl/releases/tag/GEOS-v3.8.0%2B1 , the files are already compiled with -O2 before this PR, but the dll are large in size. Therefore this PR is not effective to reduce the size. Closing this PR.