Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade HDF5 library version #262

Merged
merged 3 commits into from
Dec 4, 2019
Merged

Upgrade HDF5 library version #262

merged 3 commits into from
Dec 4, 2019

Conversation

musm
Copy link
Contributor

@musm musm commented Dec 4, 2019

No description provided.

@giordano
Copy link
Member

giordano commented Dec 4, 2019

Do we need to increase the version number, too?

@musm
Copy link
Contributor Author

musm commented Dec 4, 2019

I guess I forgot to bump the previous version in the PR?

@musm
Copy link
Contributor Author

musm commented Dec 4, 2019

I did a minor version bump, since we upgraded the library version and also upgraded to include libhdf5_hl

giordano
giordano reviewed Dec 4, 2019
View reviewed changes
H/HDF5/build_tarballs.jl Outdated Show resolved Hide resolved
@giordano
Copy link
Member

giordano commented Dec 4, 2019

JLL packages don't follow semantic versioning, we just use the same version as the upstream package.

@musm
Copy link
Contributor Author

musm commented Dec 4, 2019

Ok well we have a weird situation in that case, since the linux and macos versions are not the same as the windows versions

@musm
Copy link
Contributor Author

musm commented Dec 4, 2019

We should be fine to keep it as is then.

@musm
Copy link
Contributor Author

musm commented Dec 4, 2019

v1.10.5 best reflects the library version

@musm
Copy link
Contributor Author

musm commented Dec 4, 2019

Is it possible to make a release after this is merged? THanks

@giordano
Copy link
Member

giordano commented Dec 4, 2019

Each merged pull request triggers a new release. I'm waiting for JuliaRegistries/General#6259 to be merged in order to avoid conflicts

@giordano giordano merged commit abb14fe into JuliaPackaging:master Dec 4, 2019
@musm musm deleted the patch-3 branch December 5, 2019 00:49
@musm
Copy link
Contributor Author

musm commented Dec 5, 2019

Thanks.

Is there however an issue with the version number since I want my users to use build +1 as a minimum and the package manager ignores build numbers for minimum compat versions?

This was referenced Jun 2, 2020
Merged
Closed
@giordano giordano added the HDF5 5️⃣ Builders and issues related to HDF5 label Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giordano giordano giordano left review comments

Assignees
No one assigned
Labels
HDF5 5️⃣ Builders and issues related to HDF5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@musm @giordano