-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FFTW] Build for experimental platforms #3585
Conversation
fdc6d0b
to
5c77b43
Compare
5c77b43
to
f6e8d22
Compare
I'm seeing if I can get an actual new release one more time FFTW/fftw3#248 (comment) |
@staticfloat Quick question, the 1:1 mapping of (raw) binary versions to Julia _jll versions is ingenious and simplifies many things except where it makes things infinitely more complicated like with the min 1.6 version / adding experimental platforms transition. Any thoughts about whether this set up feels 'solved' or worth tweaking? |
Absolutely! Mosè and I have discussed this at length. The critical design error is that we try to shove semantically useful information into the "build number" of the JLL version number (e.g. the After a lot of back and forth with the Pkg team, (of which I am also a part) we decided that we would eventually decouple JLL version numbers from upstream source numbers, and we would have an automated tool to help keep track of what the "true" version number is. So, as an example, you would have a table somewhere that looks something like:
And then we would have tooling to allow you to do things like ask "what version of the fftw binary do I actually have?", and "Allow me to specify version requirements on the actual library version itself", which would basically translate to the JLL version number ranges. |
To be clear though, this tooling doesn't exist yet. :) |
@staticfloat Nice! Thanks for the clear explanation, makes a lot of sense! |
The chain of notifications went from me to Valentin to Steven to Matteo, but we finally managed to get a new version of FFTW released! |
…ing#3585) * [FFTW] Build for experimental platforms * Update build_tarballs.jl * Update build_tarballs.jl Co-authored-by: Jeremiah Lewis <[email protected]> Co-authored-by: Elliot Saba <[email protected]>
FFTW.jl now requires Julia 1.6. In order to support experimental platforms like Apple Silicon, a new FFTW_jll needs to be built with an updated version number and then FFTW.jl can be updated. This PR seeks to resolve the open point for FFTW in #2763.