Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GibbsSeaWater_jll update #5001

Merged
merged 7 commits into from
Jun 10, 2022
Merged

GibbsSeaWater_jll update #5001

merged 7 commits into from
Jun 10, 2022

Conversation

kouketsu
Copy link
Contributor

@kouketsu kouketsu commented Jun 9, 2022

Update for support platforms

G/GibbsSeaWater/build_tarballs.jl Outdated Show resolved Hide resolved
G/GibbsSeaWater/build_tarballs.jl Outdated Show resolved Hide resolved
Copy link
Member

@giordano giordano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You still haven't changed the version number, which is mandatory. Isn't there a newer upstream release to build?

G/GibbsSeaWater/build_tarballs.jl Outdated Show resolved Hide resolved
G/GibbsSeaWater/build_tarballs.jl Outdated Show resolved Hide resolved
@kouketsu
Copy link
Contributor Author

I'm sorry I have took mistakes many times. Thank you for your support @giordano.
I have bumped the version.

@kouketsu kouketsu requested a review from giordano June 10, 2022 03:37
@kouketsu kouketsu requested a review from giordano June 10, 2022 12:49
G/GibbsSeaWater/build_tarballs.jl Outdated Show resolved Hide resolved
G/GibbsSeaWater/build_tarballs.jl Outdated Show resolved Hide resolved
G/GibbsSeaWater/build_tarballs.jl Outdated Show resolved Hide resolved
@kouketsu kouketsu requested a review from giordano June 10, 2022 23:28
Copy link
Member

@giordano giordano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good now, thanks for your contribution!

@giordano giordano merged commit 87bb687 into JuliaPackaging:master Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants