Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makie.jl extension #145

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

longemen3000
Copy link
Contributor

@longemen3000 longemen3000 commented May 16, 2023

Based on #123 . but using the 1.9 extensions mechanism. should solve #95, MakieOrg/Makie.jl#875 . Tests missing. (just call Makie.convert_arguments, it seems)

@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Merging #145 (3a9a0a0) into master (ba8305f) will not change coverage.
The diff coverage is n/a.

❗ Current head 3a9a0a0 differs from pull request most recent head f62db9e. Consider uploading reports for the commit f62db9e to get more accurate results

@@           Coverage Diff           @@
##           master     #145   +/-   ##
=======================================
  Coverage   96.91%   96.91%           
=======================================
  Files           9        9           
  Lines         616      616           
=======================================
  Hits          597      597           
  Misses         19       19           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ffreyer
Copy link

ffreyer commented May 16, 2023

Looks good to me.

Maybe it also make sense to add conversion methods for rangebars and crossbar?

MeasurementsRecipesBaseExt = "RecipesBase"
MeasurementsSpecialFunctionsExt = "SpecialFunctions"
MeasurementsUnitfulExt = "Unitful"

[extras]
Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
Juno = "e5e0dc1b-0480-54bc-9374-aad01c23163d"
Makie = "ee78f7c6-11fb-53f2-987a-cfe4a2b5a57a"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't used, is it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not at the moment, ideally, i would like to add some tests, but i'm not familiar enough with the makie testing infraestructure

ext/MeasurementsMakieExt.jl Outdated Show resolved Hide resolved
ext/MeasurementsMakieExt.jl Outdated Show resolved Hide resolved
src/Measurements.jl Outdated Show resolved Hide resolved
@giordano
Copy link
Member

Aqua is disappointed again

@longemen3000
Copy link
Contributor Author

ohhh, it seems that aqua was updated? the position is the correct one this time

@giordano giordano mentioned this pull request May 28, 2023
@giordano
Copy link
Member

What's the status of this? I don't use Makie, I can't offer any feedback, I don't even have any idea of what a plot with Makie looks like with this PR since no image was shared anywhere.

@giordano giordano mentioned this pull request May 28, 2023
@longemen3000
Copy link
Contributor Author

tests are missing. the main way to test images is to use ReferenceTests and compare the plot with a standard image: https://github.com/JuliaGeometry/MeshViz.jl/blob/master/test/runtests.jl

@hz-xiaxz
Copy link

Hi, this is a lovely feature. Has the work been progressing anymore?

@giordano
Copy link
Member

Doesn't look like it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants