-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makie.jl extension #145
base: master
Are you sure you want to change the base?
Makie.jl extension #145
Conversation
Codecov Report
@@ Coverage Diff @@
## master #145 +/- ##
=======================================
Coverage 96.91% 96.91%
=======================================
Files 9 9
Lines 616 616
=======================================
Hits 597 597
Misses 19 19 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Looks good to me. Maybe it also make sense to add conversion methods for rangebars and crossbar? |
MeasurementsRecipesBaseExt = "RecipesBase" | ||
MeasurementsSpecialFunctionsExt = "SpecialFunctions" | ||
MeasurementsUnitfulExt = "Unitful" | ||
|
||
[extras] | ||
Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595" | ||
Juno = "e5e0dc1b-0480-54bc-9374-aad01c23163d" | ||
Makie = "ee78f7c6-11fb-53f2-987a-cfe4a2b5a57a" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't used, is it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not at the moment, ideally, i would like to add some tests, but i'm not familiar enough with the makie testing infraestructure
Aqua is disappointed again |
ohhh, it seems that aqua was updated? the position is the correct one this time |
What's the status of this? I don't use Makie, I can't offer any feedback, I don't even have any idea of what a plot with Makie looks like with this PR since no image was shared anywhere. |
tests are missing. the main way to test images is to use |
Hi, this is a lovely feature. Has the work been progressing anymore? |
Doesn't look like it. |
Based on #123 . but using the 1.9 extensions mechanism. should solve #95, MakieOrg/Makie.jl#875 . Tests missing. (just call
Makie.convert_arguments
, it seems)