Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jd/dev #1

Merged
merged 9 commits into from
Aug 31, 2022
Merged

Jd/dev #1

merged 9 commits into from
Aug 31, 2022

Conversation

joshday
Copy link
Collaborator

@joshday joshday commented Aug 29, 2022

Tests working for String, PlotlyLight, and PlotlyJS plots.

@sglyon
Copy link
Member

sglyon commented Aug 30, 2022

This looks very nice! Would you be able to help resolve the merge conflicts?

@joshday
Copy link
Collaborator Author

joshday commented Aug 30, 2022

The PlotlyLight/PlotlyJS test for the eps extension fails for a reason I can't figure. It works when the input is a JSON string. Otherwise I'd say this is good to go.

src/Kaleido.jl Outdated Show resolved Hide resolved
test/runtests.jl Outdated Show resolved Hide resolved
@BeastyBlacksmith BeastyBlacksmith merged commit e9a3f43 into main Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants