Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle chars #2124

Merged
merged 1 commit into from
Aug 7, 2019
Merged

handle chars #2124

merged 1 commit into from
Aug 7, 2019

Conversation

daschw
Copy link
Member

@daschw daschw commented Aug 6, 2019

Plots cannot (no longer?) deal with Chars as input. This came up in #2123.
This change should fix the problem.

@daschw daschw requested a review from yha August 6, 2019 12:08
@daschw daschw mentioned this pull request Aug 6, 2019
Closed
mkborregaard
mkborregaard approved these changes Aug 6, 2019
View reviewed changes
Copy link
Member

@mkborregaard mkborregaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@daschw daschw merged commit 0deb703 into JuliaPlots:master Aug 7, 2019
@daschw daschw removed the request for review from yha August 7, 2019 07:20
@yha
Copy link
Member

yha commented Aug 8, 2019

Wouldn't that be better handled by a type recipe?

@recipe f(::Type{<:AbstractChar}, ::AbstractChar) = (string, string)

@daschw
Copy link
Member Author

daschw commented Aug 8, 2019

Good point. Feel free to change, if that works as well.

@yha yha mentioned this pull request Aug 8, 2019
Merged
@daschw daschw deleted the chars branch October 13, 2019 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkborregaard mkborregaard mkborregaard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daschw @yha @mkborregaard