Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore non-allocating generator - bump coverage #4470

Merged
merged 40 commits into from
Oct 23, 2022
Merged

Conversation

t-bltg
Copy link
Member

@t-bltg t-bltg commented Oct 21, 2022

I've used a named tuple with Refs in _update_min_padding! since RefField is not implemented yet (see JuliaLang/julia#35453).

extra checks:

  • docs build
  • benchmarks

batch

main() = begin
  for i in 1:62
    script = """
    using Logging, BenchmarkTools, Plots
    ex(i) = begin
      pl = Plots.test_examples(:gr, i, disp=false)
      Plots.png(pl, "gr-$i")
      Plots.pdf(pl, "gr-$i")
      nothing
    end
    with_logger(true ? NullLogger() : current_logger()) do
      i = parse(Int, first(ARGS))
      Plots._examples[i].imports === nothing || exit(0)
      print("$(lpad(i, 2)))")
      if true
        @btime ex($i) samples = 1 evals = 1  # 1 warmup + 1 eval
      else
        b = @benchmarkable ex($i)
        t = run(b, samples = 10)
        show(IOContext(stdout, :compact => false), t)
        println()
      end
    end
    """
    run(`$(Base.julia_cmd()) -e $script $i`)
  end
end

main()

1.35.5

PR

@t-bltg t-bltg marked this pull request as draft October 21, 2022 12:02
@codecov
Copy link

codecov bot commented Oct 21, 2022

Codecov Report

Base: 88.32% // Head: 89.64% // Increases project coverage by +1.31% 🎉

Coverage data is based on head (248975d) compared to base (79d873a).
Patch coverage: 89.43% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4470      +/-   ##
==========================================
+ Coverage   88.32%   89.64%   +1.31%     
==========================================
  Files          40       40              
  Lines        7863     7656     -207     
==========================================
- Hits         6945     6863      -82     
+ Misses        918      793     -125     
Impacted Files Coverage Δ
RecipesBase/src/RecipesBase.jl 90.65% <0.00%> (ø)
RecipesPipeline/src/series_recipe.jl 93.10% <0.00%> (ø)
src/backends/hdf5.jl 84.50% <0.00%> (ø)
src/examples.jl 98.33% <ø> (ø)
src/components.jl 89.81% <25.00%> (-0.27%) ⬇️
src/output.jl 95.57% <50.00%> (+12.09%) ⬆️
src/recipes.jl 81.19% <56.25%> (+1.49%) ⬆️
src/args.jl 84.31% <74.35%> (+0.15%) ⬆️
src/backends/unicodeplots.jl 96.63% <80.00%> (+0.44%) ⬆️
src/pipeline.jl 96.04% <88.23%> (-0.08%) ⬇️
... and 26 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@t-bltg t-bltg added nfc non-functional change CI continuous integration labels Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI continuous integration coverage deadcode nfc non-functional change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant