Move js code to separate JS module #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still not working
Still to make style look nicer, width breaks sometime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will not be merged directly, but it tracks the progress towards moving the whole javascript machinery in PlutoPlotly into a separate JS library.
Once this works as intended it will be actually put into a separate repository and just loaded by this package as an artifact.
This will reduce the amount of javascript in julia which is difficult to follow/debug, and will allow more easily to load this library outside of Pluto to bring the enhanced functionality (resizing and copy to clipboard) also in the REPL or in VSCode.