Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] PR with artifact preview #8

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

[feat] PR with artifact preview #8

wants to merge 12 commits into from

Conversation

sosiristseng
Copy link
Member

close #6

@sosiristseng
Copy link
Member Author

sosiristseng commented Dec 16, 2021

However, I kept getting errors on "Comment on PR about the artifact link" github action:

https://github.com/sosiristseng/static-export-template/runs/4544460466?check_suite_focus=true

Edit: the latest commit fixed that

https://github.com/sosiristseng/static-export-template/actions/runs/1586404343

Copy link
Contributor

@greimel greimel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be nice to have!

Could someone re-trigger CI to verify that the artifacts look good?

name: Add artifact links to pull request and related issues
on:
workflow_run:
workflows: ["Export Pluto notebooks"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
workflows: ["Export Pluto notebooks"]
workflows: [Export Pluto notebooks]

In the examples you linked to, there are no quotation marks

@greimel
Copy link
Contributor

greimel commented Jul 29, 2022

I used your code in greimel/pluto-course-template#15 - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notebook preview for PRs
2 participants