Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easier to add or remove multiple packages w/ Vector{String} #135

Merged
merged 5 commits into from
Jul 11, 2024

Conversation

mkitti
Copy link
Member

@mkitti mkitti commented Jul 4, 2024

Currently one cannot add or remove packages as indicated by a Vector{String} see #134

This pull request allows for the following syntax.

CondaPkg.add(["jsonlines", "cowpy"])
CondaPkg.rm(["jsonlines", "cowpy"])

It implements this by creating a function _to_spec with two methods.
For an existing *Spec, it just returns the spec. For an AbstractString,
it returns a PkgSpec.

@cjdoris
Copy link
Collaborator

cjdoris commented Jul 7, 2024

@mkitti Thanks! Looks good. However the tests are failing on Windows for some mysterious reason that seems irrelevant to this PR (#137), I'm assuming it's a bug in micromamba. Can you replace the 4 packages in the test with jsonlines and cowpy since these are smaller and faster to install and aren't numpy please? This should make the tests pass.

test/main.jl Outdated Show resolved Hide resolved
@cjdoris cjdoris merged commit 2a90c67 into JuliaPy:main Jul 11, 2024
8 checks passed
@cjdoris
Copy link
Collaborator

cjdoris commented Jul 11, 2024

Thanks 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants