-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On anaconda_conda #560
Comments
I'm okay with removing the |
tkf
added a commit
to tkf/PyCall.jl
that referenced
this issue
Sep 22, 2018
stevengj
pushed a commit
that referenced
this issue
Sep 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I propose to stop unconditionally installing conda packages in
pyimport_conda
when Conda.jl is not used:PyCall.jl/src/PyCall.jl
Lines 657 to 663 in 49029e0
If a user explicitly sets
$PYTHON
then it means s/he do not want auto-magical handling of Python packages by Conda.jl. Installing package automatically at runtime is not what programmers would expect, I hope (unless, say, there is some integrity check like GPG verification). I can think of several options to fix it:CONDA_JL_HOME
handle this case and remove thisif !isempty(aconda)
branch.isinteractive()
then prompt user before executingconda install
.If you are going to take an option like 3, I think there is one more thing to be fixed:
PyCall.jl/src/PyCall.jl
Lines 662 to 663 in 49029e0
I don't think any package should modify user's configuration silently. Why not use
conda install --channel $channel ...
like this?:The text was updated successfully, but these errors were encountered: