-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing property is_rational #369
Comments
Yes, that seems to make sense. I'll try to put in a PR when I get a chance. Thanks! |
Do you mind if I take a stab at it? |
jverzani
added a commit
to jverzani/SymPy.jl
that referenced
this issue
Aug 31, 2020
Sorry, missed this. I just did it.
…On Mon, Aug 31, 2020 at 3:50 PM Michele Zaffalon ***@***.***> wrote:
Do you mind if I take a stab at it?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#369 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADG6TEPSUQUZB4OZUTOQJ3SDP5IHANCNFSM4QQST55A>
.
--
John Verzani
Department of Mathematics
College of Staten Island, CUNY
[email protected]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It looks like
is_rational
is not set for certain types on masterThis leads to the following error:
I forgot most of my Python, but it looks like sympy also fails to set the property correctly. Would in this case make sense e.g. in
SymPy.jl/src/numbers.jl
Lines 53 to 54 in 382a805
The text was updated successfully, but these errors were encountered: