Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and document @vars renaming with pair syntax #393

Merged
merged 2 commits into from
Dec 5, 2020

Conversation

knuesel
Copy link
Contributor

@knuesel knuesel commented Dec 5, 2020

This fixes the support for variable=>name syntax in @vars, and adds a few mentions of this syntax in the documentation.

There's also a minor fix in the Readme for the CI badge.

@jverzani
Copy link
Collaborator

jverzani commented Dec 5, 2020

Thanks! Will merge once all goes through.

@codecov-io
Copy link

codecov-io commented Dec 5, 2020

Codecov Report

Merging #393 (213c0aa) into master (c929d0e) will increase coverage by 0.19%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #393      +/-   ##
==========================================
+ Coverage   46.91%   47.11%   +0.19%     
==========================================
  Files          17       17              
  Lines        1021     1021              
==========================================
+ Hits          479      481       +2     
+ Misses        542      540       -2     
Impacted Files Coverage Δ
src/constructors.jl 83.01% <100.00%> (+3.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c929d0e...213c0aa. Read the comment docs.

@jverzani jverzani merged commit 45f7efb into JuliaPy:master Dec 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants