Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tilde, following Symbolics; fix issue from #425 #426

Merged
merged 2 commits into from
May 24, 2021

Conversation

jverzani
Copy link
Collaborator

  • add ~ as an alternative to lhs \Equal[tabl] rhs or Eq(lhs, rhs) so that comparisons with Symbolics are easier.
  • fix space issue exposed in response to issue adjoint(a) != conj(a) for a::Sym #425

@codecov-commenter
Copy link

codecov-commenter commented May 22, 2021

Codecov Report

Merging #426 (93404b7) into master (5a98def) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #426      +/-   ##
==========================================
- Coverage   54.02%   54.02%   -0.01%     
==========================================
  Files          18       18              
  Lines        1155     1168      +13     
==========================================
+ Hits          624      631       +7     
- Misses        531      537       +6     
Impacted Files Coverage Δ
src/constructors.jl 88.46% <ø> (ø)
src/mathfuns.jl 68.18% <33.33%> (-1.23%) ⬇️
src/numbers.jl 52.48% <60.00%> (+2.83%) ⬆️
src/types.jl 35.41% <0.00%> (-5.06%) ⬇️
src/matrix.jl 71.62% <0.00%> (-0.85%) ⬇️
src/lambdify.jl 93.22% <0.00%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a98def...93404b7. Read the comment docs.

@jverzani jverzani merged commit 7a2f451 into JuliaPy:master May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants