Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix SymPySymbolicUtilsExt extension #516

Merged
merged 2 commits into from
Aug 25, 2023
Merged

Conversation

t-bltg
Copy link
Contributor

@t-bltg t-bltg commented Aug 25, 2023

Fix #515.

Extensions (weak dependencies) should be tested in CI by adding a using <weak dependencies> to runtests.jl in order to trigger extension loading.

cc @jverzani, please merge & tag asap ? Thanks.

@t-bltg t-bltg changed the title fix ext fix SymPySymbolicUtilsExt extension Aug 25, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (618eb38) 56.05% compared to head (ac811e5) 56.05%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #516   +/-   ##
=======================================
  Coverage   56.05%   56.05%           
=======================================
  Files          20       20           
  Lines        1247     1247           
=======================================
  Hits          699      699           
  Misses        548      548           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jverzani
Copy link
Collaborator

Thank you. Sorry about this.

@jverzani jverzani merged commit eb0c0a5 into JuliaPy:master Aug 25, 2023
10 checks passed
@t-bltg t-bltg deleted the fix_ext branch August 25, 2023 11:54
@t-bltg
Copy link
Contributor Author

t-bltg commented Aug 25, 2023

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing latest release
3 participants