Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate functions not supported in SymPyCore #533

Merged
merged 9 commits into from
Oct 21, 2023

Conversation

jverzani
Copy link
Collaborator

@jverzani jverzani commented Oct 18, 2023

Add deprecation warnings for move to SymPyCore backend.

Some deprecations have been hard to incorporate and are listed here. None should be so disruptive, save perhaps the first two:

True -> Sym(true)
False -> Sym(false)

sympy_core -> sympy.core
sympy_matrices -> sympy.matrices

@symfuns, @vars

@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2023

Codecov Report

Attention: 50 lines in your changes are missing coverage. Please review.

Comparison is base (473447b) 56.15% compared to head (b6dca29) 55.81%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #533      +/-   ##
==========================================
- Coverage   56.15%   55.81%   -0.34%     
==========================================
  Files          20       21       +1     
  Lines        1259     1263       +4     
==========================================
- Hits          707      705       -2     
- Misses        552      558       +6     
Files Coverage Δ
src/SymPy.jl 62.00% <ø> (ø)
src/constructors.jl 88.88% <100.00%> (+0.20%) ⬆️
src/importexport.jl 23.76% <ø> (+0.94%) ⬆️
src/lambdify.jl 93.42% <100.00%> (ø)
src/sets.jl 77.77% <100.00%> (+6.34%) ⬆️
src/symfunction.jl 70.00% <ø> (ø)
src/utils.jl 78.62% <100.00%> (+0.16%) ⬆️
src/generic.jl 43.75% <50.00%> (ø)
src/permutations.jl 0.00% <0.00%> (ø)
src/plot_recipes.jl 0.00% <0.00%> (ø)
... and 2 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jverzani jverzani merged commit d7610a5 into JuliaPy:master Oct 21, 2023
10 checks passed
@jverzani jverzani deleted the deprecations branch October 21, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants