Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: SingleFieldStructArrays v0.3.2 #86584

Conversation

JuliaRegistrator
Copy link
Contributor

UUID: 5dd5ea32-d67d-426d-b4ce-2ad113187929
Repo: https://github.com/OpenMDAO/SingleFieldStructArrays.jl.git
Tree: 43cc507a55aec2c87ebac7927aa4081bffeb7ff4

Registrator tree SHA: f73a20c99934db92a256057d0d83ba394036a701
@github-actions
Copy link
Contributor

Your new package pull request met all of the guidelines for auto-merging and is scheduled to be merged when the mandatory waiting period (3 days) has elapsed.

Since you are registering a new package, please make sure that you have read the package naming guidelines: https://julialang.github.io/Pkg.jl/dev/creating-packages/#Package-naming-guidelines-1


If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment. You can edit blocking comments, adding [noblock] to them in order to unblock auto-merging.

@aplavin
Copy link
Contributor

aplavin commented Jun 30, 2023

Seems like mapview function can be used instead of SingleFieldStructArray with exact same performance. It is even more general and shorter to type :)
Eg:

# either vanilla:
mapview(x->x.t, foos)
# or even, for convenience:
mapview(:t, foos)

# instead of
SingleFieldStructArray(foos, Val{:t})

The mapview function is available in either SplitApplyCombine.jl (older, more popular) or FlexiMaps.jl (newer, more focused and featureful).

Not to discourage the package, especially in case if there are any non-trivial advantages of SingleFieldStructArray. At least I think these advantages (wrt mapview that has been around for a long time) should be highlighted in the readme.

@jishnub
Copy link
Contributor

jishnub commented Jun 30, 2023

[noblock]

Could you highlight what are the advantages of this package over StructArrays.jl?

@dingraha
Copy link

@aplavin Excellent, thanks for the comment. As you might have guessed, I was unaware of both SplitApplyCombine.jl and FlexiMaps.jl's mapview. :-) FlexiMaps.mapview appears to do exactly what I want, and so I don't see any need to register this package.

@jishnub Re: SingleFieldStructArrays.jl vs StructArrays.jl, my understanding is that they do opposite things. StructArrays.jl takes a struct of Arrays and makes it look like an Array of structs. SingleFieldStructArrays.jl takes an array of structs and makes it look like an array of one of the struct elements.

@github-actions
Copy link
Contributor

This pull request has been inactive for 30 days and will be automatically closed 7 days from now. If this pull request should not be closed, please either (1) fix the AutoMerge issues and re-trigger Registrator, which will automatically update the pull request, or (2) post a comment explaining why you would like this pull request to be manually merged. [noblock]

@github-actions github-actions bot added the stale label Jul 31, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

This pull request has been inactive for more than 30 days and has automatically been closed. Feel free to register your package or version again once you fix the AutoMerge issues. [noblock]

@github-actions github-actions bot closed this Aug 8, 2023
@github-actions github-actions bot deleted the registrator-singlefieldstructarrays-5dd5ea32-v0.3.2-df097c3069 branch August 8, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants