Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reference test for AutoMerge comment (and all its permutations) #547

Merged
merged 5 commits into from
Jun 9, 2024

Conversation

ericphanson
Copy link
Member

This is a test-only change that adds ReferenceTests as a test-dep and uses it to test the AutoMerge comment. What this allows us to do is surface changes to the generated comment in PR diffs. This is a first step at #150.

When the comment changes and you run tests interactively, ReferenceTests.jl will provide you an easy way to update the references (and fail the tests). If they are not updated, CI will fail, so we can be sure they are up-to-date.

@ericphanson ericphanson added this pull request to the merge queue Jun 9, 2024
@ericphanson
Copy link
Member Author

nightly CI failure is unrelated; not sure if it will let me merge though

@DilumAluthge
Copy link
Member

nightly CI failure is unrelated; not sure if it will let me merge though

It should let you merge.

Merged via the queue into master with commit 2f3134b Jun 9, 2024
10 of 11 checks passed
@ericphanson ericphanson deleted the eph/ref-test branch June 9, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants