update for newer General branch format #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DilumAluthge
requested review from
christopher-dG
and removed request for
christopher-dG
IanButterworth
force-pushed
the
ib/general_branch_fix
branch
from
1d790de
to
655bb41
Compare
IanButterworth
changed the title
IanButterworth
force-pushed
the
ib/general_branch_fix
branch
3 times, most recently
from
e0f0acd
to
e8d1ef7
Compare
|
@christopher-dG are you the right person to ping on this? If not who'd be good? |
|
Bump |
IanButterworth
force-pushed
the
ib/general_branch_fix
branch
10 times, most recently
from
764ca4f
to
3507e83
Compare
IanButterworth
force-pushed
the
ib/general_branch_fix
branch
from
3507e83
to
27ccd08
Compare
christopher-dG
approved these changes
Aug 24, 2023
|
It'd be good to test this in the wild. Does the bot pick up new releases immediately? |
|
I actually realized that I should not have asked you to bump the version yourself, since the release script does that automatically. Oops! I'll revert just that change then run the release workflow. |
|
Sounds good. Worth getting any other dep bump PRs in while we're here? |
This was referenced Aug 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #263
Fixes #258
Fixes #262
Not sure how to test this before merge given tests didn't fail while this was broken.