Skip to content
This repository has been archived by the owner on Aug 11, 2023. It is now read-only.

Enhance_ActionTransformedEnv #88

Conversation

findmyway
Copy link
Member

No description provided.

@findmyway findmyway merged commit 00125d6 into JuliaReinforcementLearning:master Oct 19, 2020

discrete_env = env |> ActionTransformedEnv(
a -> get_actions(env)[a]; # action index to action
mapping = x -> Dict(x => i for (i, a) in enumerate(get_actions(env)))[x] # arbitrary vector to DiscreteSpace
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be Dict(a => i for (i, a) in enumerate(get_actions(env))) instead of Dict(x => i for (i, a) in enumerate(get_actions(env)))

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I file a PR?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants