Simple copy functions #570
Conversation
Codecov Report
@@ Coverage Diff @@
## master #570 +/- ##
==========================================
- Coverage 79.86% 79.71% -0.16%
==========================================
Files 33 33
Lines 2111 2115 +4
==========================================
Hits 1686 1686
- Misses 425 429 +4
Continue to review full report at Codecov.
|
| @@ -87,6 +87,28 @@ VariableNodeData(val::Array{Float64,2}, | |||
| VariableNodeData(softtype::T; solverKey::Symbol=:default) where T <: InferenceVariable = | |||
| VariableNodeData{T}(zeros(1,1), zeros(1,1), Symbol[], Int[], 0, false, :NOTHING, Symbol[], softtype, false, 0.0, false, false, 0, 0, solverKey) | |||
|
|
|||
| ## Copying | |||
| function copy(vnd::VariableNodeData; solverKey::Union{Nothing,Symbol}=nothing) | |||
There was a problem hiding this comment.
Maybe we shouldn't overwrite expected behaviour from base copy with deepcopy?
I expect copy to return a shallow copy and deepcopy for this.
Personally I don't think we should provide too many functions. Every function has to be documented and maintained.
The user can rather just do
dcvnd = deepcopy(vnd)
dcvnd.selverKey = newKey
Is the function we are trying to replace updateSolverData!(dfg, label, vnd, newsolvekey)?
Where vnd.solvekey != newsolvekey.
Perhaps something like (although IIF needs to be updated slightly for it):
function deepcopySolverData!(dfg::AbstractDFG, label::Symbol, srcKey::Sybol, dstKey::Symbol)
vnd = deepcopy(getSolverData!(dfg, label, srcKey))
vnd.solverKey = dstKey
updateSolverData!(dfg, vnd)
end Now that I'm thinking it through. update is maybe not the correct function to use. Its adding new solverdata so maybe:
function addSolverData!(dfg::AbstractDFG, label::Symbol, vnd, solverKey::Symbol)
vnd.solverKey = dstKey
addSolverData!(dfg, vnd)
end There was a problem hiding this comment.
Cool, that works, will close this then.
This work for simple copy functions that we can use in IIF?