Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More parse_urdf API updates #513

Merged
merged 3 commits into from
Nov 9, 2018
Merged

More parse_urdf API updates #513

merged 3 commits into from
Nov 9, 2018

Conversation

tkoolen
Copy link
Collaborator

@tkoolen tkoolen commented Nov 9, 2018

…cceleration.

Also introduce DEFAULT_GRAVITATIONAL_ACCELERATION constant, and widen
the signature to AbstractVector.
@codecov-io
Copy link

codecov-io commented Nov 9, 2018

Codecov Report

Merging #513 into master will decrease coverage by 0.05%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #513      +/-   ##
==========================================
- Coverage   99.29%   99.23%   -0.06%     
==========================================
  Files          38       38              
  Lines        1696     1700       +4     
==========================================
+ Hits         1684     1687       +3     
- Misses         12       13       +1
Impacted Files Coverage Δ
src/mechanism.jl 95.55% <ø> (ø) ⬆️
src/joint_types/sin_cos_revolute.jl 100% <100%> (ø) ⬆️
src/joint_types/quaternion_floating.jl 100% <100%> (ø) ⬆️
src/joint_types/revolute.jl 100% <100%> (ø) ⬆️
src/joint.jl 100% <100%> (ø) ⬆️
src/urdf/parse.jl 94.79% <87.5%> (-0.96%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34d2fef...ca35272. Read the comment docs.

@tkoolen tkoolen merged commit 86bc94b into master Nov 9, 2018
@tkoolen tkoolen deleted the tk/parse-urdf-api-2 branch November 9, 2018 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add keyword argument to parse_urdf for setting gravitational acceleration
2 participants