Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop transforming wrenches back to body frame in inverse_dynamics. #526

Merged
merged 1 commit into from
Jan 2, 2019

Conversation

tkoolen
Copy link
Collaborator

@tkoolen tkoolen commented Jan 2, 2019

Also add transpose(jac) * wrench, etc. for convenience (used in new joint_wrenches_and_torques! implementation).

A bit faster:

`dynamics_bias!`6.64 -> 6.36
`inverse_dynamics!` 5.87 -> 5.68
`dynamics!`: 18.92 -> 17.86

Will also allow removing joint_torque!(τ::AbstractVector, joint::Joint, q::AbstractVector, joint_wrench::Wrench), thus simplifying the Joint interface and making it easier to create new JointTypes.

… body frame in inverse_dynamics; just use motion subspaces.
@codecov-io
Copy link

codecov-io commented Jan 2, 2019

Codecov Report

Merging #526 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #526      +/-   ##
==========================================
- Coverage   99.53%   99.53%   -0.01%     
==========================================
  Files          42       42              
  Lines        2788     2787       -1     
==========================================
- Hits         2775     2774       -1     
  Misses         13       13
Impacted Files Coverage Δ
src/spatial/motion_force_interaction.jl 100% <100%> (ø) ⬆️
src/spatial/spatialmotion.jl 99.12% <100%> (+0.02%) ⬆️
src/mechanism_algorithms.jl 100% <100%> (ø) ⬆️
src/joint_types/quaternion_spherical.jl 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7be1a32...ef3c627. Read the comment docs.

@tkoolen tkoolen merged commit cc92e99 into master Jan 2, 2019
@tkoolen tkoolen deleted the tk/joint-wrenches branch January 2, 2019 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants