Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove allocations in intro #105

Merged
merged 4 commits into from
Feb 21, 2023
Merged

Remove allocations in intro #105

merged 4 commits into from
Feb 21, 2023

Conversation

tmigot
Copy link
Member

@tmigot tmigot commented Feb 21, 2023

When starting form a solution, only set_solver_specific! allocates now

@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Base: 92.02% // Head: 92.81% // Increases project coverage by +0.78% 🎉

Coverage data is based on head (f01b7af) compared to base (d97b1d3).
Patch coverage: 95.55% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
+ Coverage   92.02%   92.81%   +0.78%     
==========================================
  Files           2        2              
  Lines         439      459      +20     
==========================================
+ Hits          404      426      +22     
+ Misses         35       33       -2     
Impacted Files Coverage Δ
src/CaNNOLeS.jl 92.94% <95.55%> (+0.84%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tmigot tmigot merged commit 0015ebf into main Feb 21, 2023
@tmigot tmigot deleted the zero-allocs-intro branch February 21, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant