Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor hessian structure using dispatch #115

Merged
merged 1 commit into from
Mar 3, 2023
Merged

Refactor hessian structure using dispatch #115

merged 1 commit into from
Mar 3, 2023

Conversation

tmigot
Copy link
Member

@tmigot tmigot commented Feb 28, 2023

Remove remaining allocations (superseded #108 );
Should also simplify adding new hessian models.

@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Patch coverage: 75.51% and project coverage change: -1.29 ⚠️

Comparison is base (e8b7761) 93.01% compared to head (ad9f854) 91.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
- Coverage   93.01%   91.73%   -1.29%     
==========================================
  Files           2        3       +1     
  Lines         487      508      +21     
==========================================
+ Hits          453      466      +13     
- Misses         34       42       +8     
Impacted Files Coverage Δ
src/hessian_approx.jl 53.84% <53.84%> (ø)
src/CaNNOLeS.jl 93.63% <100.00%> (+0.82%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tmigot tmigot merged commit d484949 into main Mar 3, 2023
@tmigot tmigot deleted the refactor branch March 3, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant