Line-search solver for Armijo-Goldstein conditions #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #213 +/- ##
==========================================
+ Coverage 97.75% 98.14% +0.38%
==========================================
Files 8 9 +1
Lines 223 269 +46
==========================================
+ Hits 218 264 +46
Misses 5 5 ☔ View full report in Codecov by Sentry. |
|
d-monnet
changed the title
|
I will modify/add tests to have a full coverage of |
dpo
requested changes
Mar 12, 2024
Co-authored-by: Dominique <[email protected]>
Co-authored-by: Dominique <[email protected]>
|
|
… (ht recomputation missing).
|
|
Co-authored-by: Tangi Migot <[email protected]>
Co-authored-by: Tangi Migot <[email protected]>
|
|
…rs as keyword arguments
…Tools.jl into armijo-goldstein
|
|
|
|
tmigot
reviewed
Mar 14, 2024
|
|
dpo
requested changes
Apr 14, 2024
update docstring Co-authored-by: Dominique <[email protected]>
Co-authored-by: Dominique <[email protected]>
|
|
Co-authored-by: Dominique <[email protected]>
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a line-search solver for the Armijo-Goldstein conditions.
This is a direct implementation (M=0, no incumbent memory) of the method proposed in:
Cartis, C., Sampaio, P.R., Toint, P.L.: Worst-case evaluation complexity of non-monotone gradient-related algorithms for unconstrained optimization. Optimization 64(5), 1349–1361 (2015).