-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bring coverage of fixed SparseMatrixCSC to 100% #392
Conversation
Codecov Report
@@ Coverage Diff @@
## main #392 +/- ##
==========================================
- Coverage 93.84% 92.19% -1.65%
==========================================
Files 12 12
Lines 7521 7521
==========================================
- Hits 7058 6934 -124
- Misses 463 587 +124
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Co-authored-by: Daniel Karrasch <[email protected]>
Seems like there are still two untested methods: SparseMatrixCSC(m, n, colptr::ReadOnly, rowval::ReadOnly, nzval::Vector)
FixedSparseCSC{Tv,Ti}(x::AbstractSparseMatrixCSC) |
@SobhanMP Any chance we can add coverage for the other two methods? Would be nice to get this PR in time for 1.10. |
@ViralBShah change in codecov seems unrelated, this should be 100% |
@dkarrasch can i merge? |
Yes, go ahead. |
No description provided.