Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test suite: activate a temp project if we need to install Aqua.jl during the test suite #425

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

DilumAluthge
Copy link
Contributor

@DilumAluthge
Copy link
Contributor Author

@Wimmerer How do you handle backports here? Is it sufficient for me to add the label to the PR?

@rayegun
Copy link
Member

rayegun commented Aug 23, 2023

The last time we had backports was 1.8 I believe and Kristoffer handled them. I can look at his script and see if that will work here. We should standardize across all the external stdlibs

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #425 (1d1b3ff) into main (18b7fce) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #425   +/-   ##
=======================================
  Coverage   92.41%   92.41%           
=======================================
  Files          12       12           
  Lines        7669     7669           
=======================================
  Hits         7087     7087           
  Misses        582      582           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@DilumAluthge
Copy link
Contributor Author

We should document somewhere the process for doing backports on an external stdlib.

@IanButterworth You've been taking care of backports for Pkg.jl for the past few releases. Would you be able to write up some instructions?

@DilumAluthge DilumAluthge merged commit 3d1eda9 into main Aug 23, 2023
9 checks passed
@DilumAluthge DilumAluthge deleted the dpa/aqua branch August 23, 2023 22:28
matbesancon pushed a commit to matbesancon/SparseArrays.jl that referenced this pull request Sep 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants