This repository has been archived by the owner on May 4, 2019. It is now read-only.
Fix mapreduce() in a corner case #281
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalimilan
force-pushed
the
nl/mapreduce
branch
2 times, most recently
from
f0a241a
to
eca6161
Compare
mapreduce_seq_impl() does not exist in Base for a long time, but this went unnoticed because since that code path is only used in very special conditions. Another consequence of this bug is that the return type of mapreduce_pairwise_impl_skipna() was inferred as Any. Add a test which would have triggered the failure. Also rename a variable to fix a type instability due to using it for two different things.
ararslan
approved these changes
Aug 2, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mapreduce_seq_impl()does not exist in Base for a long time (JuliaLang/julia#16217), but this went unnoticed because since that code path is only used in very special conditions.Another consequence of this bug is that the return type of
mapreduce_pairwise_impl_skipna()was inferred asAny.Add a test which would have triggered the failure.
Also rename a variable to fix a type instability due to using it for two
different things.