Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump compat for StatsBase 0.34 #529

Merged
merged 1 commit into from
May 2, 2023
Merged

bump compat for StatsBase 0.34 #529

merged 1 commit into from
May 2, 2023

Conversation

palday
Copy link
Member

@palday palday commented May 2, 2023

see also #528

@palday palday requested a review from nalimilan May 2, 2023 01:26
@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2c170e3) 87.39% compared to head (fd29f0c) 87.39%.

Additional details and impacted files
@@           Coverage Diff           @@
##               v1     #529   +/-   ##
=======================================
  Coverage   87.39%   87.39%           
=======================================
  Files           7        7           
  Lines         952      952           
=======================================
  Hits          832      832           
  Misses        120      120           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@palday palday requested a review from ararslan May 2, 2023 01:36
@ararslan
Copy link
Member

ararslan commented May 2, 2023

Looks like CI ran with StatsBase 0.33 because something else is upper-bounding it.

@ararslan
Copy link
Member

ararslan commented May 2, 2023

Ah, it's StatsModels. So we'll need JuliaStats/StatsModels.jl#291

@palday
Copy link
Member Author

palday commented May 2, 2023

Don't know why Julia nightly is failing, but the other versions run with StatsBase 0.34

image

@kleinschmidt
Copy link
Member

I think nightly failures are the same as we see in StatsModels:

saturated linear model: Error During Test at /home/runner/work/GLM.jl/GLM.jl/test/runtests.jl:207
  Expression evaluated to non-Boolean

although looking at the tests, I don't see why (in my experience this is caused by @test_broken normally accepting non-boolean values in 1.8 or earlier)

@ararslan
Copy link
Member

ararslan commented May 2, 2023

We could backport #514 to the v1 branch. That PR fixed that issue.

@palday palday merged commit f874482 into v1 May 2, 2023
@palday palday deleted the pa/sb34 branch May 2, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants