Set minimum Julia version to 1.6 (#514) #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Set minimum Julia version to 1.6 Currently the minimum version is 1.0, which is old and unsupported and makes development and addition of new features more difficult. * Fix nightly CI In Julia 1.10, at-test_broken will error if the expression doesn't evaluate to a boolean value, making it consistent with at-test. We actually can fit the model here; the test passes with prior Julia versions only because the expression doesn't evaluate to a boolean. (cherry picked from commit 57669ef)
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## v1 #530 +/- ##
=======================================
Coverage 87.39% 87.39%
=======================================
Files 7 7
Lines 952 952
=======================================
Hits 832 832
Misses 120 120 ☔ View full report in Codecov by Sentry. |
ararslan
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the minimum version is 1.0, which is old and unsupported and
makes development and addition of new features more difficult.
In Julia 1.10, at-test_broken will error if the expression doesn't
evaluate to a boolean value, making it consistent with at-test. We
actually can fit the model here; the test passes with prior Julia
versions only because the expression doesn't evaluate to a boolean.
(cherry picked from commit 57669ef)