Fix null deviance and use Ref
instead of Ptr
#57
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the computation of the null deviation for the Gaussian family and test it with the output of the R package. Fixes #39.
The implementation is basically copied from the implementation in the R package in the file
R/elnet.R
:It has to be computed before the
ccall
since the call modifies the weights in-place and additionallyy
ifstandardize = true
. Maybe it would be good to alwayscopy
the weights andcopy
y
ifstandardize = true
- at least for me this behaviour was quite surprising and confusing.Additionally, I changed the types in the
ccall
s according to the Julia documentation:The vectors of fixed length 1 in the
ccall
are replaced withRef
.