BACKPORT: LRT for comparing non-mixed to mixed models #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* LRT for comparing non-mixed to mixed models * nesting for LM/GLMM and GLM/LMM * NEWS entry * use _iscomparable instead of isnested * add missing dep * inner has no more preds than outer, thx @kleinschmidt * column span check * oops * julia 1.4 compat * condition LRT show method on G/LMM * use deviance for GLM and -2 loglikelihood for LMM * contains -> occursin (Julia 1.4 compat) * Apply suggestions from code review Co-authored-by: Dave Kleinschmidt <[email protected]> * copy-paste error * reenable a shortcut * Apply suggestions from code review Co-authored-by: Douglas Bates <[email protected]> Co-authored-by: Dave Kleinschmidt <[email protected]> Co-authored-by: Douglas Bates <[email protected]> (cherry picked from commit 365e5f7)
Codecov Report
@@ Coverage Diff @@
## v3.x #510 +/- ##
==========================================
+ Coverage 93.91% 94.06% +0.14%
==========================================
Files 24 24
Lines 2105 2155 +50
==========================================
+ Hits 1977 2027 +50
Misses 128 128
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cf #508.