Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix allpars for zerocorr #570

Merged
merged 5 commits into from
Sep 17, 2021
Merged

Fix allpars for zerocorr #570

merged 5 commits into from
Sep 17, 2021

Conversation

palday
Copy link
Member

@palday palday commented Sep 16, 2021

Closes #569

There seems to be a new issue in the docs when predict is called on a model with a function term (e.g. division) in the response. For now, I've just made a work-around.

@codecov
Copy link

codecov bot commented Sep 16, 2021

Codecov Report

Merging #570 (8030e83) into main (1636e65) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #570      +/-   ##
==========================================
+ Coverage   96.16%   96.24%   +0.08%     
==========================================
  Files          28       28              
  Lines        2500     2503       +3     
==========================================
+ Hits         2404     2409       +5     
+ Misses         96       94       -2     
Impacted Files Coverage Δ
src/bootstrap.jl 99.30% <100.00%> (+1.41%) ⬆️
src/predict.jl 98.14% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1636e65...8030e83. Read the comment docs.

@palday palday requested a review from dmbates September 16, 2021 16:30
@palday palday merged commit 694faa1 into main Sep 17, 2021
@palday palday deleted the pa/bstrzc branch September 17, 2021 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

shortestcovint() and .allpars fail for bootstrap results of zerocorr model
2 participants