get rid of CategoricalArrays #157
Conversation
Depends on having a levels method defined in DataAPI, which it currently does not. Also, there were a few functions from Missings that snuck in because CategoricalArrays reexports it.
|
This will also depend on Categorical Arrays pulling in |
|
@nalimilan pointed out that we can still use the specialized |
src/modelframe.jl
Outdated
| res[i] &= el > 0 | ||
| end | ||
| end | ||
| # TODO: find another way to optimize this without taking a dependency |
There was a problem hiding this comment.
Just remove this thanks to JuliaData/CategoricalArrays.jl#218.
There was a problem hiding this comment.
does this mean that we need to change these methods to use broadcast instead of doing a loop?
|
I think this is ready now that Missings, DataAPI, and CategoricalArrays have all had releases. |
Codecov Report
@@ Coverage Diff @@
## master #157 +/- ##
=========================================
- Coverage 84.87% 84.78% -0.1%
=========================================
Files 9 9
Lines 496 493 -3
=========================================
- Hits 421 418 -3
Misses 75 75
Continue to review full report at Codecov.
|
Depends on having a levels method defined in DataAPI (or elsewhere),
which it currently does notwhich it does since 1.1.0. Also, there were a few functions from Missings that snuck in because CategoricalArrays reexports it.