Use Symbols as column names #136
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4,7 +4,7 @@ | |||
| for op in [:.+, :.-, :.*, :./] | |||
| @eval begin | |||
| function ($op){T,N}(ta1::TimeArray{T,N}, ta2::TimeArray{T,N}) | |||
| cname = [ta1.colnames[1][1:2] * string($op) * ta2.colnames[1][1:2]] | |||
| cname = [string(ta1.colnames[1])[1:2] * string($op) * string(ta2.colnames[1])[1:2]] | |||
There was a problem hiding this comment.
Maybe this should be dried out. string(ta1.colnames[1])[1:2] appears a few times here.
|
I'm closing this for now since the motivation behind using Symbols vs Strings for column names doesn't seem to be an improvement and will disallow spaces in column names. |
|
Apologies, I thought this was long closed. Thanks. |
|
No problem. Thanks for tossing it out there for us to consider. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #134
Should work as before when passing strings as column names: they're cast as symbols.
New to Julia so comments/thoughts/pointers welcome.
Now I think about it maybe should also check identifiers (again inline with DataFrames), but I don't think there is a Base implementation of that yet?...