Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fast implementation of iterate #30

Merged
merged 3 commits into from
Nov 3, 2020
Merged

Fast implementation of iterate #30

merged 3 commits into from
Nov 3, 2020

Conversation

ScottPJones
Copy link
Member

No description provided.

@ScottPJones ScottPJones mentioned this pull request Nov 2, 2020
Merged
@ScottPJones
Copy link
Member Author

@xiaodaigh @oxinabox Could you all review this please?

xiaodaigh
xiaodaigh requested changes Nov 2, 2020
View reviewed changes
Copy link
Collaborator

@xiaodaigh xiaodaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need some test cases for the iterate.

oxinabox
oxinabox reviewed Nov 2, 2020
View reviewed changes
src/base.jl Outdated Show resolved Hide resolved
@ScottPJones
Copy link
Member Author

@xiaodaigh I added Lyndon's tests (using collect to test iterate)

@ScottPJones ScottPJones merged commit a3ab08e into JuliaString:master Nov 3, 2020
@ScottPJones ScottPJones deleted the spj/iterate branch November 3, 2020 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxinabox oxinabox oxinabox left review comments

@xiaodaigh xiaodaigh Awaiting requested review from xiaodaigh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ScottPJones @xiaodaigh @oxinabox