replaced version test with test for defined symbols #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Or we could just test for the correct version. |
|
Closing since we no longer support Julia 0.5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks if
Base.ASCIIStringis defined before redefining legacy string types. This helps keep early 0.5-dev versions functional (cf. #6).I did not attempt to do the pedantic thing and test for each of the legacy types separately, because
support.jlcontains references to all of them anyways. Thus this PR will not help with Julia versions that fall in the middle of the great Stringapalooza refactoring: JuliaLang/julia#16107