Fix build warnings #58
Merged
+122
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use relative symlinks that are independent of installation prefix. Drop superfluous .so.MAJOR.MINOR symlink, which is and should never be needed in practice. The purpose of shared library symlinks is to provide libraries for compile-time linking (.so) and for run-time linking using the SONAME (.so.MAJOR).
This resolves warnings for missing function prototypes.
|
Thanks! This looks good to me, apart from the few comments I have added inline. Also, it's funny that the test you added to check that |
Generate reproducible manifest of installed files.
| endif | ||
|
|
||
| MANIFEST.new: | ||
| rm -rf INSTALL |
There was a problem hiding this comment.
Probably call it tmp or similar rather than INSTALL.
(In GNU packages, INSTALL is a file with installation instructions.)
There was a problem hiding this comment.
I have renamed the directory to tmp.
| @@ -1,5 +1,6 @@ | |||
| /* Common functions and includes for our test programs. */ | |||
|
|
|||
| #define _XOPEN_SOURCE 700 | |||
There was a problem hiding this comment.
Would be nice to add a comment for why this is needed.
|
Thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit series fixes several build warnings, and ensures that
make cleanreverts the build tree to a pristine state. This is the last pull request in an effort to bring utf8proc into shape for distribution packaging, specifically for Debian.