Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed solve_multipoly #1259

Merged
merged 4 commits into from
Sep 7, 2024
Merged

Conversation

n0rbed
Copy link
Member

@n0rbed n0rbed commented Sep 4, 2024

Since now solve_multivar can handle all cases solved by solve_multipoly, therefore the GCD usage is unnecessary given Groebner basis can handle more generalized input (this pr for example).

@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 37.57%. Comparing base (47cfd60) to head (1d797fb).
Report is 89 commits behind head on master.

Files with missing lines Patch % Lines
src/solver/main.jl 75.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1259       +/-   ##
===========================================
+ Coverage    8.30%   37.57%   +29.26%     
===========================================
  Files          46       46               
  Lines        4549     4559       +10     
===========================================
+ Hits          378     1713     +1335     
+ Misses       4171     2846     -1325     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas
Copy link
Member

Real test failures.

@n0rbed
Copy link
Member Author

n0rbed commented Sep 7, 2024

Real test failures.

fixed

@n0rbed
Copy link
Member Author

n0rbed commented Sep 7, 2024

i dont think the tests failing in core are related to me

@ChrisRackauckas ChrisRackauckas merged commit 97d9cad into JuliaSymbolics:master Sep 7, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants