Handle BasicSymbolic expressions in test
#1260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The testing expression generator generates expressions of type
`Symbolics.BasicSymbolic{Number}` when all the selected variables are of
that type (generated by `@syms` instead of `@variables`).
Add a method to wrap these expressions with a `Num` before checking for
cancelation.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1260 +/- ##
===========================================
+ Coverage 8.30% 80.81% +72.50%
===========================================
Files 46 47 +1
Lines 4549 4728 +179
===========================================
+ Hits 378 3821 +3443
+ Misses 4171 907 -3264 ☔ View full report in Codecov by Sentry. |
|
This is missing a test? |
|
This fixes a fuzz test that was failing locally, I'm not sure why it doesn't happen in CI. I'll extract the failing example and add it as a new test. |
|
Fuzz tests are a random. That sounds like something good to isolate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The testing expression generator generates expressions of type
Symbolics.BasicSymbolic{Number}when all the selected variables are of that type (generated by@symsinstead of@variables).Add a method to wrap these expressions with a
Numbefore checking for cancelation.